-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom fontFamily in <SvgChart /> #110
Conversation
Signed-off-by: Florian Rohrer <dev@florianrohrer.ch>
|
Signed-off-by: Florian Rohrer <dev@florianrohrer.ch>
i have now removed the use of |
Thanks, we'll check the history and confirm if we can just remove the code. |
Now, We may can't remove this code
|
How can I change the font on individual chart components if this attribute is filtered out? Additionally if I use an unavailable/invalid font in a chart I would expect an error to occur, so I don't see why this change shouldn't be possible. |
We need to change the default font settings and allow for custom fonts |
fix: handle echart defalut font unrecognized error in ios
Thanks for merging 👍 please release a new version of the package if possible, thanks |
1.2.5 |
While trying to use the
<SvgChart />
I noticed that i can't set custom fonts for any of the elements. I noticed that the fontFamily prop is not properly set on the react-native-svg<Text/>
element.The following changes fix this issue:
fontStyleReg
thetest
function is stateful(documentation). This makes the second style not match the regex. Switching tomatchAll
resolves this issue. Alternatively the global flag could be removed from the regex, butmatchAll
is better showing the intent of the code.font-family
is no longer ignored on purpose. Based on the code and history I could not figure out why this condition was there in the first place.