Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for styling set chart size #118

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

xuanweiH
Copy link
Collaborator

No description provided.

src/types.ts Outdated
@@ -58,6 +58,9 @@ export type SkiaChartProps = CommonChartProps & {
svg?: string;
width?: number;
height?: number;
style?: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的类型定义可否使用 import { ViewStyle } from 'react-native'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

Signed-off-by: xuanweiH <525405891@qq.com>
Signed-off-by: huangxuanwei <huangxuanwei@58.com>
@zhiqingchen zhiqingchen merged commit db44967 into main Sep 18, 2023
6 checks passed
@zhiqingchen zhiqingchen deleted the feat/style-fit branch September 18, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants