Timeout errors shouldn't silently ignore the passed errors, but rathe…

…r reject with original error. Fixes knex#2582
wubzz · May 23, 2018 · 91390b5 · 91390b5
1 parent db390b1
commit 91390b5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/transaction.js b/src/transaction.js
@@ -100,15 +100,15 @@ export default class Transaction extends EventEmitter {
     return this.query(conn, 'ROLLBACK;', 2, error)
       .timeout(5000)
       .catch(Promise.TimeoutError, () => {
-        this._resolver();
+        this._rejecter(error);
       });
   }
 
   rollbackTo(conn, error) {
     return this.query(conn, `ROLLBACK TO SAVEPOINT ${this.txid}`, 2, error)
       .timeout(5000)
       .catch(Promise.TimeoutError, () => {
-        this._resolver();
+        this._rejecter(error);
       });
   }