Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加网易云音乐插件,并修改微博插件样式 #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quanru
Copy link
Contributor

@quanru quanru commented Jul 19, 2015

在widgets中添加插件music,之后在author中添加music_id:

在widgets中添加插件music,之后在author中添加music_id:
@wuchong
Copy link
Owner

wuchong commented Aug 27, 2015

PR 中有二维码相关的改动, 能否将这部分改动去掉,只保留网易云音乐的改动代码。

@quanru
Copy link
Contributor Author

quanru commented Aug 27, 2015

我印象中没有改啊,二维码?

'<a href="#" class="overlay" id="qrcode"></a>',
'<div class="qrcode clearfix"><span>扫描二维码分享到微信朋友圈</span><a class="qrclose" href="#nothing"></a><strong>Loading...Please wait</strong><img id="qrcode-pic" data-src="http://s.jiathis.com/qrcode.php?url=' + encodedUrl + '"/></div>',
'<div class="hoverqrcode clearfix"></div>',
'<a class="overlay" id="qrcode"></a>',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件的代码,修改了二维码, 与网易云插件代码不相关,所以最好移除这部分的修改。

@quanru
Copy link
Contributor Author

quanru commented Aug 27, 2015

被我改冲突了,能否直接用master上对应的文件覆盖吗?

@snowdream
Copy link

期待合并网易云音乐widget进来。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants