Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomLoginPage.routing is undefined #290

Closed
pklaschka opened this issue Feb 5, 2021 · 0 comments · Fixed by #294
Closed

CustomLoginPage.routing is undefined #290

pklaschka opened this issue Feb 5, 2021 · 0 comments · Fixed by #294
Labels
📋 telestion-client-template Everything related to the telestion-client-template. 🚧 bug Something isn't working 🎩 telestion-client-common Everything related to the telestion-client-common.
Milestone

Comments

@pklaschka
Copy link
Member

Example code to reproduce (from template):

import {
	LoginPage as TCLoginPage,
	LoginTitle,
	LoginLogo,
	LoginForm,
    LoginDescription
} from "@wuespace/telestion-client-common";

export function LoginPage(...props: any) {
	return (
		<TCLoginPage {...props}>
			<LoginLogo />
			<LoginTitle />
			<LoginDescription />
			<LoginForm initialServerURL="http://localhost:9870/bridge" />
		</TCLoginPage>
	);
}

Easiest Workaround:

Add the following line below all other code in that file:

LoginPage.routing = TCLoginPage.routing;

This needs to get adjusted in all doc comments (probably all overall usages of <LoginPage> or <TCLoginPage>), as well.

Data Value
Affected versions >=0.6.0
@pklaschka pklaschka added 🚧 bug Something isn't working 🎩 telestion-client-common Everything related to the telestion-client-common. 📋 telestion-client-template Everything related to the telestion-client-template. labels Feb 5, 2021
@pklaschka pklaschka added this to the v0.6.1 milestone Feb 5, 2021
fussel178 pushed a commit that referenced this issue Feb 5, 2021
…ntation

Adds the necessary `routing` property to the custom login page component and fixes the order of logo and title.

Closes: #290
Closes: #292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 telestion-client-template Everything related to the telestion-client-template. 🚧 bug Something isn't working 🎩 telestion-client-common Everything related to the telestion-client-common.
Projects
None yet
1 participant