-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PNPM and Parcel #1372
Merged
Merged
PNPM and Parcel #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I viewed all the changes and only can approve the work. Good job.
Also the build time became a lot faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 enhancement
New feature or request
🔗 dependencies
Pull requests that update a dependency file
🏃 github_actions
Pull requests that update Github_actions code
📜 javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces changes in monorepo handling and the build pipeline.
Details
Due to multiple issues with npm in the past, we should switch to pnpm.
It has native monorepo support and convenient workspace linking and better dependency resolution and installation performance. Installed dependencies are isolated and only have access to their direct dependencies which prevents usage of invalid package versions. (the counterpart of hoisting)
Additionally we should also switch to Parcel as our main build tool. Rollup has served us good in the past, but Parcel supports our special monorepo support much better while less configuration setup is needed.
It plays very well with pnpm.
As a nice addition the compile times improve drastically.
To test these changes, you need to install pnpm first:
Then, clear your current build files:
And checkout:
To use the new tooling, take a look and the new contributing guidelines.
Some of the test tooling currently don't work due to package manager changes. (especially storybook)
They're working on support for pnpm.
Additional information
n/a
Related links
CLA