Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): Divide login page into compound components and document them #282

Merged
merged 13 commits into from
Feb 5, 2021
Merged

feat(common): Divide login page into compound components and document them #282

merged 13 commits into from
Feb 5, 2021

Conversation

fussel178
Copy link
Member

Changes

  • Divide login page into compound components
  • Document all modules belonging to login page
  • add recommended or "default" behaviour of the login page to the template

@fussel178
feat(common): Divide login page into compound components for better u…
2da7630 
…sability

Notice: To use the default login page, please refactor your current application login page to:
```ts
<LoginPage>
  <LoginTitle />
  <LoginLogo />
  <LoginDescription />
  <LoginForm />
</LoginPage>
```
@fussel178
feat(common): Make initial values for text fields in login form acces…
a5f3245 
…sible for project
@fussel178
style(common): ESLint disable max lines for form component
e9df10c
@fussel178 fussel178 added 🔨 enhancement New feature or request 🎩 telestion-client-common Everything related to the telestion-client-common. 📋 telestion-client-template Everything related to the telestion-client-template. labels Feb 5, 2021
@fussel178 fussel178 added this to the v1.0.0 milestone Feb 5, 2021
@fussel178 fussel178 self-assigned this Feb 5, 2021
@fussel178 fussel178 marked this pull request as ready for review February 5, 2021 03:22
pklaschka
pklaschka requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comments for a few recommendations, here and there. Other than that, it looks good to me 🙂

packages/telestion-client-common/src/components/pages/login-page/login-form/form/form.model.ts Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-form/form/form.model.ts Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-form/form/form.tsx Outdated Show resolved Hide resolved
...ges/telestion-client-common/src/components/pages/login-page/login-form/form/login-button.tsx Outdated Show resolved Hide resolved
...ges/telestion-client-common/src/components/pages/login-page/login-form/form/login-button.tsx Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-form/form/text-field.tsx Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-form/login-form.tsx Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-form/login-form.tsx Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-page.tsx Outdated Show resolved Hide resolved
packages/telestion-client-common/src/components/pages/login-page/login-page.tsx Outdated Show resolved Hide resolved
@fussel178 @pklaschka
docs(common): Apply suggestions from code review for login page
f17052d 
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Feb 5, 2021

Code Climate has analyzed commit f17052d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

pklaschka
pklaschka approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 👍 😃

@fussel178 fussel178 merged commit 12b8af7 into main Feb 5, 2021
@fussel178 fussel178 deleted the feat/common/login-page branch February 5, 2021 03:48
@pklaschka pklaschka mentioned this pull request Feb 5, 2021
Closed
@pklaschka pklaschka modified the milestones: v1.0.0, v0.6.0 Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pklaschka pklaschka pklaschka approved these changes

Assignees

@fussel178 fussel178

Labels
📋 telestion-client-template Everything related to the telestion-client-template. 🔨 enhancement New feature or request 🎩 telestion-client-common Everything related to the telestion-client-common.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fussel178 @pklaschka