Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

feat(widgets): Implement Waveform - and Spectrogram widgets #11

Merged
merged 21 commits into from
Mar 2, 2021
Merged

feat(widgets): Implement Waveform - and Spectrogram widgets #11

merged 21 commits into from
Mar 2, 2021

Conversation

jantischhoefer
Copy link
Member

@jantischhoefer jantischhoefer commented Feb 5, 2021 •
edited
Loading

Initial pull request for discussion and feedback on widget implementation.

TODOs:

  • handle resizes of application and resize
  • switch setInterval to reception of real amplitude from backend
  • maybe implement Buffer for more consistent data flow (paused)
  • cosmetic enhancement of widget (Axis ticks, grid, etc.)
  • support multiple waveforms
  • documentation
  • tests

@jantischhoefer jantischhoefer added the enhancement New feature or request label Feb 5, 2021
@jantischhoefer jantischhoefer self-assigned this Feb 5, 2021
@fussel178 fussel178 changed the title Initial waveform widget implementation feat(widgets): Initial waveform widget implementation Feb 25, 2021
@jantischhoefer jantischhoefer marked this pull request as ready for review February 27, 2021 15:00
@jantischhoefer
Copy link
Member Author

Basic functionality works and can be merged.

jantischhoefer and others added 15 commits February 27, 2021 16:32
@jantischhoefer
Small documentation
969a358
@fussel178
refactor(widget): Clean up waveform widget
9263bd4
@pklaschka
Merge branch 'main' into feat-waveform
13b9c4f 
# Conflicts:
#	src/model/channels.ts
#	src/model/sample-user-config.ts
#	src/widgets/index.ts
@pklaschka
chore: Enhancements and integration in preparation to merge into main
9888379
@pklaschka
chore: Temp commit
83a5c79
@fussel178
chore: Refactor and clean up waveform widget
df645f3
@fussel178
feat: Add spectrum color hook
4a6283b
@fussel178
feat: Improve waveform widget and clean up again
2bde031
@fussel178
feat: Graph widget now uses spectrum colors
d4fa5c2
@fussel178
fix(widget): Add aria label to table in 9dof-widget
61f6ae3
@fussel178
fix(widget): Add keys to react list
b3b0e36
@pklaschka
feat: Implement Spectrogram widget
80444e6
@pklaschka
fix: StateWidget formatting inconsistencies
5389d8d
@pklaschka
fix: Map widget formatting inconsistencies
4b23f43
@pklaschka
fix: 9dof Table widget formatting inconsistencies
b9d09ca
@pklaschka pklaschka changed the title feat(widgets): Initial waveform widget implementation feat(widgets): Implement Waveform - and Spectrogram widgets Mar 2, 2021
@pklaschka pklaschka merged commit 9178004 into main Mar 2, 2021
@pklaschka pklaschka deleted the feat-waveform branch March 2, 2021 02:07
@fussel178 fussel178 mentioned this pull request May 18, 2021
Open
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jantischhoefer jantischhoefer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jantischhoefer @pklaschka @fussel178