Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support gitee #33

Merged
merged 1 commit into from
Jan 31, 2020
Merged

feature: support gitee #33

merged 1 commit into from
Jan 31, 2020

Conversation

kitewu
Copy link
Contributor

@kitewu kitewu commented Jan 31, 2020

Support Gitee platform.

Changlogs:

  • add gitee-client, include: getToken(), createFile(), updateFile(), getFileContent()
  • gitee-service: include: updateRepo()

Signed-off-by: WuShaoling wsl6@outlook.com

@menbotics menbotics bot added the kind/feature Category issues or prs related to feature request. label Jan 31, 2020
@frank-zsy
Copy link
Contributor

需要看一下 Lint 情况,这个项目没有用 TSLint,使用了 ESLint,需要装一下对应的 IDE 插件

Signed-off-by: WuShaoling <wsl6@outlook.com>
@codecov-io
Copy link

Codecov Report

Merging #33 into master will decrease coverage by 8.61%.
The diff coverage is 16.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   47.28%   38.67%   -8.62%     
==========================================
  Files          15       17       +2     
  Lines         184      256      +72     
  Branches        4        6       +2     
==========================================
+ Hits           87       99      +12     
- Misses         97      157      +60
Impacted Files Coverage Δ
config/config.default.ts 100% <100%> (ø) ⬆️
app/component/gitee-client.ts 11.76% <11.76%> (ø)
app/service/shimo.ts 24.32% <14.28%> (-2.95%) ⬇️
app/service/gitee.ts 22.22% <22.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7b165...e55fc05. Read the comment docs.

@kitewu
Copy link
Contributor Author

kitewu commented Jan 31, 2020

需要看一下 Lint 情况,这个项目没有用 TSLint,使用了 ESLint,需要装一下对应的 IDE 插件

我加了 tslint,需要去掉吗

@frank-zsy
Copy link
Contributor

我加了 tslint,需要去掉吗

那就都留着吧,是两个同时生效吗?有插件检查的话问题不大。

@frank-zsy
Copy link
Contributor

没有改 package.json ,应该二选一就行了

@frank-zsy
Copy link
Contributor

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Jan 31, 2020
@frank-zsy frank-zsy merged commit c7b61a3 into wuhan2020:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or prs related to feature request. pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants