Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

完成医疗人员指定酒店解析代码 #73

Merged
merged 24 commits into from
Feb 11, 2020

Conversation

tyisme614
Copy link
Contributor

@tyisme614 tyisme614 commented Feb 6, 2020

Purpose | 本PR解决的问题

根据表结构,完成医疗人员指定酒店解析代码。

Changes | 本PR的更改

  • No changes.

Checklist | 检查

  • Are tests written for added code? | 新增代码是否添加测试用例
  • Yes
  • No because: 可使用石墨表格数据进行测试
  • Did you introduce any new dependencies? | 如果添加新的依赖,请列出依赖并说明添加该依赖的原因
  • No
  • Yes
    • Dependency:
    • Reason:

2.added function for retrieving cached location data.
the function would calculate the similarity between the given address and cached address.
if the calculated similarity value is larger than 0.9, then the cached data would be returned.
3.removed Baidu configuration from config.default.ts
added baidu api key configuration in config file
call function checkURLConnectivity to check the url connectivity
config/config.default.ts Outdated Show resolved Hide resolved
@tyisme614
Copy link
Contributor Author

另外有个小问题,在石墨文档 https://shimo.im/sheets/Hd9C3QytrJK3RWxG中, ‘酒店可提供房间数’这个表头里貌似多了一个 tab字符 是否可以让有编辑权限的同学把tab删除掉,不然在调用 getCellByName的时候担心无法解析到这个表头。

@tyisme614
Copy link
Contributor Author

‘酒店辖区(县区级)’ 这个表头里的括号是全角的,所以我在代码里也用了全角的括号。但是感觉习惯上都会默认用半角的括号吧?

@frank-zsy
Copy link
Contributor

另外有个小问题,在石墨文档 https://shimo.im/sheets/Hd9C3QytrJK3RWxG中, ‘酒店可提供房间数’这个表头里貌似多了一个 tab字符 是否可以让有编辑权限的同学把tab删除掉,不然在调用 getCellByName的时候担心无法解析到这个表头。

嗯,这个我让他们改一下

@frank-zsy
Copy link
Contributor

‘酒店辖区(县区级)’ 这个表头里的括号是全角的,所以我在代码里也用了全角的括号。但是感觉习惯上都会默认用半角的括号吧?

全角可以的,中文中应该用全角的

@codecov-io
Copy link

Codecov Report

Merging #73 into master will decrease coverage by 0.98%.
The diff coverage is 14.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   28.35%   27.37%   -0.99%     
==========================================
  Files          25       26       +1     
  Lines         522      559      +37     
  Branches       24       25       +1     
==========================================
+ Hits          148      153       +5     
- Misses        374      406      +32
Impacted Files Coverage Δ
app/service/github.ts 25% <0%> (ø) ⬆️
app/service/qiniu.ts 18.75% <0%> (ø) ⬆️
config/config.default.ts 100% <100%> (ø) ⬆️
app/external_api/api_isaaclin.ts 40% <100%> (ø) ⬆️
app/service/shimo.ts 13.15% <11.76%> (-0.71%) ⬇️
app/schema/table_patient_detail.ts 15.78% <15.78%> (ø)
app/service/data_format.ts 35% <16.66%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01dd478...d7a574f. Read the comment docs.

@frank-zsy
Copy link
Contributor

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Feb 11, 2020
@menbotics menbotics bot merged commit 90a681a into wuhan2020:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 接入湖北医疗人员指定休息酒店表
3 participants