Add support for psycopg2-ctypes #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
psycopg2ct related fixes |
|
Did you close this pull request on purpose? I never tried txpostgres with psycopg2ct, I'll be sure to try it this week. Does this make txpostgres run on PyPy? That would be great! About the commits themselves, the patch that checks whether the file descriptor is negative - why is this necessary? I guess it's some kind of a race condition, but if you have a repeatable test case that reproduces the bug, it would be great (and I could add a test case along with the commit). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for psycopg2-ctypes (fix bug with binding connect function to object)