Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors on Travis (Linux) #27

Closed
wooorm opened this issue Sep 23, 2015 · 3 comments
Closed

Compilation errors on Travis (Linux) #27

wooorm opened this issue Sep 23, 2015 · 3 comments

Comments

@wooorm
Copy link
Collaborator

wooorm commented Sep 23, 2015

Hey @nathanjsweet,

First off: great project, thanks a lot!
Second: I just created a lot of easily insoluble dictionaries, maybe useful for the other nodehun users (or the README?)

And third, I’m getting compilation errors on Travis when building on Node 0.10, 0.11, 0.12, iojs, and 4.0. They seems to be related to nodehun rather than my module. Here are the logs: https://travis-ci.org/wooorm/retext-spell/builds/81763026. Also interesting: there’s a difference between the old node versions (e.g., 0.12) and new versions (e.g., 4.0).

I’m hopeful that you can shed some light on these errors! Thanks!

@nathanjsweet
Copy link
Collaborator

I'll take a look.

@wooorm
Copy link
Collaborator Author

wooorm commented Sep 29, 2015

Thanks @nathanjsweet!

@nathanjsweet
Copy link
Collaborator

Titus, you are getting compilation errors for iojs and 4.0, as I have not yet updated nodehun to conform to their new C++ api. However, you are not getting compilation errors on the other versions. It looks like your tests are running and a test of yours is failing. I downloaded your en_GB dictionary and tried passing the same string to spellSuggestions, which it looks like what you are doing here, and it worked fine for me (I definitely didn't get the malloc error you're seeing).

It looks like you're doing some complicated stuff like abstracting strings into objects. Could it be that your VFile or NLCSTNode objects have some undefined behaviors around odd UTF-8 characters?

I'm closing unless you have new information for me that I'm not seeing.

Hope this helps. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants