Fix "Could not start recording within 5 seconds" bug #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into what I think was a race condition with starting the recorder. Sometimes
this.waitForEvent('onStart')wasn't returning in time and the timeout was causes the recorder to stop. But when I looked Aperture was recording the file.I think this was because it was calling
this.waitForEvent('onStart'). Once whenthis.isFileReadywas being created and again at the bottom of thestartRecordingmethod. I was able to fix this problem by relying onisFileReadyinstead ofthis.waitForEvent('onStart'). This avoids shelling out again and still will handle the problem of a recording not starting within 5 seconds.