Require Node.js 18, move to ESM and named exports #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
changed the title
yannbertrand
changed the title
yannbertrand
force-pushed
the
migrate-to-esm
branch
2 times, most recently
from
0895262
to
da6d03c
Compare
example.js
Outdated
| const aperture = require('.'); | ||
| import fs from 'node:fs'; | ||
| import timers from 'node:timers/promises'; | ||
| import {aperture, screens, audioDevices, videoCodecs} from './index.js'; |
There was a problem hiding this comment.
Suggested change
| import {aperture, screens, audioDevices, videoCodecs} from './index.js'; | |
| import {recorder, screens, audioDevices, videoCodecs} from './index.js'; |
Would make more sense to name it recorder, since we're doing changes anyway.
There was a problem hiding this comment.
What about exporting the Recorder class? Not sure about the demos example naming
const recorder = new Recorder()There was a problem hiding this comment.
You cannot record two things at once, so I don't think being able to create a new instance is very useful.
There was a problem hiding this comment.
I exported a Recorder instance named recorder.
yannbertrand
force-pushed
the
migrate-to-esm
branch
from
da6d03c
to
333378b
Compare
yannbertrand
force-pushed
the
migrate-to-esm
branch
from
333378b
to
588b46e
Compare
sindresorhus
requested changes
Mar 26, 2024
sindresorhus
changed the title
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed ESM docs and your work on other projects.
API Breaking changes:
const aperture = require('aperture')→import {recorder} from 'aperture'await aperture().startRecording()→await recorder.startRecordingaperture.screens→import {screens} from 'aperture'aperture.audioDevices→import {audioDevices} from 'aperture'aperture.videoCodecs→import {videoCodecs} from 'aperture'ava,file-type,xoandelectron-utillast versions require Node 18 so I couldn't use them. Do you think it's worth upgrading to Node 18 now?