Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to download update from GitHub #1101

Open
Seque opened this issue Mar 3, 2022 · 1 comment
Open

Failed to download update from GitHub #1101

Seque opened this issue Mar 3, 2022 · 1 comment

Comments

@Seque
Copy link

Seque commented Mar 3, 2022

Sentry Issue: KAP-BFW

macOS version: Monterey (12)
Kap version: 3.5.2

Unhandled Promise Rejection

Error: Cannot download "https://objects.githubusercontent.com/github-production-release-asset-2e65be/65411043/dc097279-94c4-4189-adf7-7eb46e2930a0?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20220303%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20220303T202905Z&X-Amz-Expires=300&X-Amz-Signature=14ded9e5de067facf9d78c074c08405ca088590d94d4d27acf996a3251ce2927&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=65411043&response-content-disposition=attachment%3B%20filename%3DKap-3.5.4-mac.zip&response-content-type=application%2Foctet-stream", status 503: 
    at ClientRequest.<anonymous> (/Applications/Kap.app/Contents/Resources/app.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:213:34)
    at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:105:6816)
@timothyis
Copy link
Member

Looks like we need to handle errors for updates better here. What do you think @karaggeorge @sindresorhus? Does the user need to be alerted at if the download fails or shall we just put it off and try it again later?

@timothyis timothyis changed the title Unhandled Promise Rejection Failed to download update from GitHub Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants