Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marquee selection should have rectangular corners #6

Closed
timothyis opened this issue Oct 4, 2016 · 5 comments
Closed

Marquee selection should have rectangular corners #6

timothyis opened this issue Oct 4, 2016 · 5 comments

Comments

@timothyis
Copy link
Member

Not possible to remove border-radius on electron windows right now, but the cropping/marquee selection area should not have a border-radius.

@matheuss matheuss added this to the 1.0.0 milestone Nov 18, 2016
@sindresorhus
Copy link
Member

Here's the relevant Electron issue: electron/electron#414

@skllcrn skllcrn removed this from the 1.0.0 milestone Jan 29, 2017
@sindresorhus
Copy link
Member

We could also add a margin to the cropper. Like this:

--- a/app/src/renderer/css/cropper.css
+++ b/app/src/renderer/css/cropper.css
@@ -1,9 +1,12 @@
 @import 'eightpoint/dist/eight.min';

 html, body, .content {
-  width: 100%;
-  height: 100%;
-  overflow: hidden;
+  position: absolute;
+  top: 0;
+  right: 0;
+  bottom: 0;
+  left: 0;
+  margin: 3px;
 }

But then we need to take that into account for all our calculations.

screen shot 2017-05-18 at 16 11 34

@skllcrn
Copy link
Member

skllcrn commented Nov 1, 2017

Another possible temporary solution, pending a potential rewrite of the cropper @sindresorhus?
electron/electron#414 (comment)

@albinekb
Copy link
Collaborator

albinekb commented Nov 1, 2017

It's the same kind hack, we'd need to take those size differences in mind when calculating 🙁

@skllcrn
Copy link
Member

skllcrn commented Sep 24, 2018

Closed via #494

@skllcrn skllcrn closed this as completed Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants