Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening a video and exporting to gif, filename doesn't stay the same #673

Closed
kevincannon opened this issue May 16, 2019 · 2 comments · Fixed by #688
Closed

When opening a video and exporting to gif, filename doesn't stay the same #673

kevincannon opened this issue May 16, 2019 · 2 comments · Fixed by #688

Comments

@kevincannon
Copy link

macOS version: 10.14.4
Kap version: 3.0.0-beta.5

Steps to reproduce

  • Open video file. e.g. "hello.mp4"
  • Select Gif format and press export.

Current behaviour

Filename is "Kapture....gif"

Expected behaviour

  • I expected "hello.gif".
  • Usually tools that convert things keep the filename

(Love this feature in the beta BTW! ❤️)

@skllcrn
Copy link
Member

skllcrn commented May 16, 2019

We were talking about the other day @karaggeorge. Technically when you import a file it is no longer associated with the original source file, hence why the name changes, but in practice it would be better if we just kept the original name?

@skllcrn
Copy link
Member

skllcrn commented May 16, 2019

Related: #651

So, the file should actually have the right name. In the exports window we don't really have file names since most services just upload it somewhere, so we generate the title again. I guess if you use the save file service, there is a name, so we can use that instead of the default

#651 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants