Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property '1' of null #888

Closed
sentry-io bot opened this issue Jul 10, 2020 · 4 comments
Closed

TypeError: Cannot read property '1' of null #888

sentry-io bot opened this issue Jul 10, 2020 · 4 comments

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 10, 2020

Sentry Issue: KAP-5KT

TypeError: Cannot read property '1' of null
  File "app:///main/utils/encoding.js", line 17, in getEncoding
    return /.*: Video: (.*?) \(.*/.exec(error.stderr)[1];
@sindresorhus
Copy link
Member

We need to re=throw the error if there's no match.

@sohamsshah
Copy link

I would like to work on this issue

@nme077
Copy link

nme077 commented Jul 9, 2021

I’ll take a look at this issue! If it is still an issue.

@sindresorhus
Copy link
Member

This is no longer relevant since we use the nil operator:

return /.*: Video: (.*?) \(.*/.exec((error as any)?.stderr)?.[1];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants