Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve model classes with read-only properties #95

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Improve model classes with read-only properties #95

merged 4 commits into from
Mar 22, 2024

Conversation

TomasKypta
Copy link
Member

Fix #94

@TomasKypta TomasKypta requested a review from kober32 March 20, 2024 11:09
@TomasKypta TomasKypta self-assigned this Mar 20, 2024
kober32
kober32 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements.

There are some grammar issues in the added comments (like missing articles etc.), but nothing crazy.

@TomasKypta TomasKypta merged commit e0a2cab into develop Mar 22, 2024
1 check passed
@TomasKypta TomasKypta deleted the issues/94-readonly-properties branch March 22, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees

@TomasKypta TomasKypta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve model classes with read-only properties
2 participants
@TomasKypta @kober32