Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard and Error class #586

Closed
TheFaithOne opened this issue May 29, 2024 · 2 comments · Fixed by #599
Closed

Proguard and Error class #586

TheFaithOne opened this issue May 29, 2024 · 2 comments · Fixed by #599
Assignees
Labels

Comments

@TheFaithOne
Copy link

During password validation process, we're using ErrorResponseApiException as a handle to fetch remaining attempts. This however doesn't work in a release build because of proguard. Returned throwable in the response for an invalid pin is:
io.getlime.security.powerauth.networking.exceptions.FailedApiException: Abstract classes can't be instantiated! Register an InstanceCreator or a TypeAdapter for this type. Class name: io.getlime.core.rest.model.base.entity.Error

Adding keep rule in proguard for the specified class seems to resolve the issue. Would it be possible to add it to the consumer rules on your end or is this somehow an expected behavior?

Cheers

@hvge hvge added the bug label Jun 5, 2024
@hvge hvge self-assigned this Jun 5, 2024
@hvge
Copy link
Member

hvge commented Jun 5, 2024

Thanks for your report. The fix will be available for 1.8.x and 1.7.x release branches.

@hvge
Copy link
Member

hvge commented Jun 5, 2024

@TheFaithOne Could you provide a snippet of code you use to extract such information? Additionally, your custom Proguard rule that solves the problem on your end would be helpful. Thank you.

@hvge hvge closed this as completed in #599 Jun 10, 2024
hvge added a commit that referenced this issue Jun 10, 2024
hvge added a commit that referenced this issue Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants