Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native object register for Android #129

Merged
merged 11 commits into from Oct 25, 2022

Conversation

hvge
Copy link
Member

@hvge hvge commented Oct 19, 2022

This PR adds native object register implementation for Android platform. On top of that, there are a lot of changes in the native code:

  • Resolved biometric key is no longer exposed to JS
  • Added constants for all error codes to Errors.java
  • PowerAuthSDK instances are now managed by object register too.

The following changes were added to JS:

  • Improved testapp. The application now displays a progress and allows us to run interactive tests.

@hvge hvge requested a review from kober32 October 19, 2022 15:04
@hvge hvge changed the title Android: Fix #95: Native object register for iOS platform Native object register for Android Oct 19, 2022
Base automatically changed from issues/95-native-object-register-ios to develop October 19, 2022 18:22
…bject-register-android

# Conflicts:
#	ios/PowerAuth/PowerAuthObjectRegister+JS.m
#	testapp/_tests/NativeObjectRegister.test.ts
#	testapp/_tests/PowerAuth_Biometry.test.ts
#	testapp/src/App.tsx
The same functionality will be added to iOS as a part of secure password impl.
@hvge hvge merged commit 9677695 into develop Oct 25, 2022
@hvge hvge deleted the issues/95-native-object-register-android branch October 25, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant