Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nativeExceptionTypeName to the promise reject on Android #189

Merged
merged 1 commit into from
May 27, 2024
Merged

Added nativeExceptionTypeName to the promise reject on Android #189

merged 1 commit into from
May 27, 2024

Conversation

kober32
Copy link
Member

@kober32 kober32 commented May 16, 2024

Resolved #188

@kober32 kober32 requested review from petrdvorak and hvge May 16, 2024 09:38
hvge
hvge approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@hvge hvge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@kober32 kober32 merged commit efc51e3 into develop May 27, 2024
@kober32 kober32 deleted the issues/188-better-android-exceptions branch May 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvge hvge hvge approved these changes

@petrdvorak petrdvorak Awaiting requested review from petrdvorak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Android IOException bridging
2 participants
@kober32 @hvge