Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom HTTP headers and Basic Auth configuration #191

Merged
merged 5 commits into from
May 28, 2024

Conversation

kober32
Copy link
Member

@kober32 kober32 commented May 20, 2024

Partially resolves #173. Request interceptors are not possible with react native, so if needed, would need to be solved in some other (native) way.

@kober32 kober32 requested review from petrdvorak and hvge May 20, 2024 17:09
Copy link
Member

@hvge hvge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. I would like you just to change the naming in interface properties, to be more web friendly.

docs/Configuration.md Outdated Show resolved Hide resolved
src/model/PowerAuthClientConfiguration.ts Outdated Show resolved Hide resolved
@kober32 kober32 requested a review from hvge May 27, 2024 11:07
Copy link
Member

@hvge hvge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@kober32 kober32 merged commit aea40f5 into develop May 28, 2024
@kober32 kober32 deleted the issues/173-more-http-features branch May 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more features to PowerAuthClientConfiguration
2 participants