better message for this usage error

wumpus · May 15, 2021 · b0f8363 · b0f8363
1 parent d4b2656
commit b0f8363
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/paramsurvey/params.py b/paramsurvey/params.py
@@ -79,6 +79,8 @@ def product_step(a, df):
 
             if not is_category:
                 a = _coerce_to_category(series)
+    else:
+        raise ValueError('invalid type {} in product construction'.format(type(a)))
 
     dfa = pd.DataFrame(a)
     dfa['asdfasdf'] = 0

diff --git a/test/unit/test_params.py b/test/unit/test_params.py
@@ -109,6 +109,10 @@ def test_product():
     assert len(df) == 8
     assert df['col3'].dtype == 'category', 'sending in a category works'
 
+    ps3 = 3
+    with pytest.raises(ValueError):
+        df = paramsurvey.params.product(df1, df2, ps3)
+
 
 def test_add_column():
     df = paramsurvey.params.product({'col1': [1, 2]}, {'col2': [3, 4]}, {'col3': [5, 6]})