Feature/ws init func (rebased on master) #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensneuse
approved these changes
Sep 6, 2022
pkg/subscription/init.go
Outdated
| package subscription | ||
|
|
||
| // InitPayload is a structure that is parsed from the websocket init message payload. | ||
| type InitPayload map[string]interface{} |
There was a problem hiding this comment.
This assumes that InitPayload is a map. What if it's any other valid JSON? Could it be an Array or a string, bool or number?
I see no other issues with this PR, but would suggest that you rewrite this to accept any kind of JSON, or maybe even a binary payload. What are your thoughts on this? (just making it a bit more generic) Nothing against the Authorization helper method. It can live in some way, but the init handler should be unopinionated.
There was a problem hiding this comment.
Looking at the type of connectionParams in subscription-transport-ws it seems to always be a map:
export declare type ConnectionParams = {
[paramName: string]: any;
};
There was a problem hiding this comment.
Ok, coming back to this one finally. I changed InitPayload to be a json.RawMessage and then trying to unmarshal it when getting a string value. That should make it handle any kind of value, right?
Changing to json.RawMessage and deferring parsing until actually trying to read a value.
* chore: add windows to build matrix chore: use math.MaxInt instead of byte shift * chore: try to fix test for windows * chore: use goldie v2 chore: replace line ending under windows goldie assertions * chore: line ending for goldie win * chore: skip goldie on a windows * fix imports pkg * chore: fix benchmark crash chore: make defer test more predictable * chore: fix stream array test * chore: update workflow * chore: disable stream test * enable goldie * revert "chore: fix benchmark crash" disable streaming tests on windows * chore: use normalize line ending in some tests * chore: ignore kafka tests on windows * chore: add step to configure git line endings in ci * chore: skip sub+federation test for windows pipeline * skip all imports test on win * Revert "chore: use normalize line ending in some tests" * chore: cleanup * chore: use separate fixtures for win in imports pkg * chore: fix build * chore: fix imports test on win * chore: cleanup
|
@spetrunin can you give this PR a review? I think it looks fine. |
Closed
|
🎉 Thanks! |
pvormste
referenced
this pull request
in TykTechnologies/graphql-go-tools
Jun 23, 2023
* Add WebSocket init function for authorizing connect * fix handleInit * fix subscripton tests * fix code style * delete debug info * chore: change InitPayload to handle any kind of data Changing to json.RawMessage and deferring parsing until actually trying to read a value. * change ci triggers * chore: add windows to build matrix (#418) * chore: add windows to build matrix chore: use math.MaxInt instead of byte shift * chore: try to fix test for windows * chore: use goldie v2 chore: replace line ending under windows goldie assertions * chore: line ending for goldie win * chore: skip goldie on a windows * fix imports pkg * chore: fix benchmark crash chore: make defer test more predictable * chore: fix stream array test * chore: update workflow * chore: disable stream test * enable goldie * revert "chore: fix benchmark crash" disable streaming tests on windows * chore: use normalize line ending in some tests * chore: ignore kafka tests on windows * chore: add step to configure git line endings in ci * chore: skip sub+federation test for windows pipeline * skip all imports test on win * Revert "chore: use normalize line ending in some tests" * chore: cleanup * chore: use separate fixtures for win in imports pkg * chore: fix build * chore: fix imports test on win * chore: cleanup Co-authored-by: chedom <domanchukits@gmail.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Sergey Petrunin <spetrunin@users.noreply.github.com>
pvormste
referenced
this pull request
in TykTechnologies/graphql-go-tools
Jun 30, 2023
* Add WebSocket init function for authorizing connect * fix handleInit * fix subscripton tests * fix code style * delete debug info * chore: change InitPayload to handle any kind of data Changing to json.RawMessage and deferring parsing until actually trying to read a value. * change ci triggers * chore: add windows to build matrix (#418) * chore: add windows to build matrix chore: use math.MaxInt instead of byte shift * chore: try to fix test for windows * chore: use goldie v2 chore: replace line ending under windows goldie assertions * chore: line ending for goldie win * chore: skip goldie on a windows * fix imports pkg * chore: fix benchmark crash chore: make defer test more predictable * chore: fix stream array test * chore: update workflow * chore: disable stream test * enable goldie * revert "chore: fix benchmark crash" disable streaming tests on windows * chore: use normalize line ending in some tests * chore: ignore kafka tests on windows * chore: add step to configure git line endings in ci * chore: skip sub+federation test for windows pipeline * skip all imports test on win * Revert "chore: use normalize line ending in some tests" * chore: cleanup * chore: use separate fixtures for win in imports pkg * chore: fix build * chore: fix imports test on win * chore: cleanup Co-authored-by: chedom <domanchukits@gmail.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Sergey Petrunin <spetrunin@users.noreply.github.com>
pvormste
added a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Jul 3, 2023
- sync wg commit: wundergraph#406 --------- Co-authored-by: chedom <domanchukits@gmail.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Sergey Petrunin <spetrunin@users.noreply.github.com>
pvormste
added a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Jul 3, 2023
- sync wg commit: wundergraph#406 --------- Co-authored-by: chedom <domanchukits@gmail.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Sergey Petrunin <spetrunin@users.noreply.github.com>
pvormste
added a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Jul 3, 2023
- sync wg commit: wundergraph#406 --------- Co-authored-by: chedom <domanchukits@gmail.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Sergey Petrunin <spetrunin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #275