feat: Use complete channel for callbacks #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you point me to the specification of the "complete" event? I'm not able to find it. Thanks. |
|
@jensneuse Sure, here's the link and it also applies to WebSockets, but I did not implement the web socket version on this PR |
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
152cec6
to
84d229f
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
84d229f
to
aa515ed
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
aa515ed
to
0a31af6
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
0a31af6
to
959e38a
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
2 times, most recently
from
de7003a
to
dc80051
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
dc80051
to
740e94c
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
740e94c
to
57f8823
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
3 times, most recently
from
9a64e48
to
5b5d4a4
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
5b5d4a4
to
a36b404
Compare
bakjos
force-pushed
the
bakjos/complete_calback
branch
from
a36b404
to
807a9e2
Compare
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphQL SSE spec includes a complete event when the stream finishes, the current implementation keeps running even when the event is received.
This PR adds support for receiving a callback when the complete event is received. I changed the API to include a channel to receive the complete event, wasn't sure if it was the right way or if we should add another method to the interfaces including the channel