Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace jsonschema library #534

Merged
merged 4 commits into from
May 16, 2023

Conversation

fiam
Copy link
Contributor

@fiam fiam commented May 15, 2023

github.com/qri-io/jsonschema has race conditions, bugs and seems to not
be maintained anymore. Use github.com/santhosh-tekuri/jsonschema/v5 instead

Registration is not goroutine-safe, run a dummy validation once to
force the registration, avoiding the race condition in subsequent
parallel runs.
Copy link
Member

@devsergiy devsergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing with this change

@fiam
Copy link
Contributor Author

fiam commented May 15, 2023

tests are failing with this change

Yep, on it

@fiam fiam changed the title fix: workaround for data race in qri-io/jsonschema fix: replace jsonschema library May 16, 2023
@fiam fiam merged commit c866e35 into master May 16, 2023
6 checks passed
@fiam fiam deleted the alberto/eng-2163-fix-data-race-in-graphql-go-tools-when branch May 16, 2023 14:06
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 23, 2023
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 26, 2023
This PR adds the following changes from wundergraph:
- wundergraph#534
- wundergraph#538
- wundergraph#540
- wundergraph#543
- wundergraph#541

---------

Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 28, 2023
This PR adds the following changes from wundergraph:
- wundergraph#534
- wundergraph#538
- wundergraph#540
- wundergraph#543
- wundergraph#541

---------

Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants