fix: ignore __typename when setting select reason #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add test coverage for this? |
|
Of course. Just wanted to get some hint on if this was reasonable or if it will break something else. |
|
Hi @argoyle Thanks a lot for your contribution Currently, we are doing a rewrite of this functionality, which may fix your issue I will let you know when we have some results |
|
@devsergiy Should I hold off on creating a test for this then? |
argoyle
force-pushed
the
ignore-typename-in-data-source-filtering
branch
from
dd7dc0a
to
5e729df
Compare
|
Added a couple of tests anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830