Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: react query client #340

Merged
merged 43 commits into from
Nov 22, 2022
Merged

feat: react query client #340

merged 43 commits into from
Nov 22, 2022

Conversation

Pagebakers
Copy link
Contributor

@Pagebakers Pagebakers commented Nov 16, 2022 •
edited

Checklist

@vercel
Copy link

vercel bot commented Nov 16, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
wundergraph-docs ⬜️ Ignored (Inspect) Nov 22, 2022 at 0:35AM (UTC)

@github-actions github-actions bot added the npm label Nov 16, 2022
@Pagebakers
Copy link
Contributor Author

Pagebakers commented Nov 17, 2022 •
edited

Fixes ENG-717
Fixes ENG-749
Fixes ENG-750
Fixes ENG-751
Fixes ENG-777

@Pagebakers Pagebakers marked this pull request as ready for review November 17, 2022 18:19
StarpTech
StarpTech requested changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you didn't add type tests?

@Pagebakers
Copy link
Contributor Author

Any reason why you didn't add type tests?

No specific reason, I'll add them.

@Pagebakers
Copy link
Contributor Author

@StarpTech Updated tests and added type tests to the package.

@Pagebakers
chore: update gen
664e94f
@Pagebakers
Merge branch 'eelco/eng-728-implement-react-query-client-integration'…
3907100 
… of github.com:wundergraph/wundergraph into eelco/eng-728-implement-react-query-client-integration
@github-actions github-actions bot added the sdk label Nov 22, 2022
StarpTech
StarpTech approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pagebakers Pagebakers removed the request for review from JivusAyrus November 22, 2022 12:32
@github-actions github-actions bot removed the engine label Nov 22, 2022
@Pagebakers Pagebakers merged commit c5769a4 into main Nov 22, 2022
@Pagebakers Pagebakers deleted the eelco/eng-728-implement-react-query-client-integration branch November 22, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

@thisisnithin thisisnithin thisisnithin approved these changes

Assignees
No one assigned
Labels
nextjs npm sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pagebakers @StarpTech @thisisnithin