Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error messages when resolving undefined variables #419

Merged
merged 5 commits into from Dec 20, 2022

Conversation

fiam
Copy link
Contributor

@fiam fiam commented Dec 8, 2022

Test before calling resolveVariable(), since by that point the information
has already been lost and it's too late to provide a more detailed message

Fixes #262

@vercel
Copy link

vercel bot commented Dec 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
wundergraph-docs ⬜️ Ignored (Inspect) Dec 20, 2022 at 1:08PM (UTC)

@fiam fiam force-pushed the alberto/eng-808-improve-missing-environment-variable branch 2 times, most recently from 0ff8661 to e69bc23 Compare December 8, 2022 11:38
Test before calling resolveVariable(), since by that point the information
has already been lost and it's too late to provide a more detailed message

Fixes #262
Copy link
Contributor

@Pagebakers Pagebakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fiam fiam requested a review from StarpTech December 20, 2022 11:24
Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fiam fiam merged commit aa0dd65 into main Dec 20, 2022
@fiam fiam deleted the alberto/eng-808-improve-missing-environment-variable branch December 20, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve wunderctl generate error messages to aid in debugging
3 participants