-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better error messages when resolving undefined variables #419
Merged
fiam
merged 5 commits into
main
from
alberto/eng-808-improve-missing-environment-variable
Dec 20, 2022
Merged
feat: better error messages when resolving undefined variables #419
fiam
merged 5 commits into
main
from
alberto/eng-808-improve-missing-environment-variable
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fiam
force-pushed
the
alberto/eng-808-improve-missing-environment-variable
branch
2 times, most recently
from
December 8, 2022 11:38
0ff8661
to
e69bc23
Compare
Test before calling resolveVariable(), since by that point the information has already been lost and it's too late to provide a more detailed message Fixes #262
Pagebakers
suggested changes
Dec 13, 2022
Helps finding where the error is
StarpTech
requested changes
Dec 15, 2022
StarpTech
requested changes
Dec 15, 2022
Pagebakers
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
StarpTech
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fiam
deleted the
alberto/eng-808-improve-missing-environment-variable
branch
December 20, 2022 13:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test before calling resolveVariable(), since by that point the information
has already been lost and it's too late to provide a more detailed message
Fixes #262