Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lua map config and number issues #1087

Merged
merged 1 commit into from Jan 14, 2024
Merged

Fix lua map config and number issues #1087

merged 1 commit into from Jan 14, 2024

Conversation

Frotty
Copy link
Member

@Frotty Frotty commented Jan 14, 2024

  • Lua config is now applied to w3i even if no buildMapData is present
  • Player config gets correctly injected into the script in lua mode
  • Use // floor division operator for translating integer division
  • Use math.tointeger to ensure correct representation of integers, aligning them with Jass

@coveralls
Copy link

Coverage Status

coverage: 62.353% (-0.04%) from 62.397%
when pulling 7b9ff0e on dev-fix-lua-issues
into dd9ac8a on master.

Copy link

sonarcloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
0.0% Coverage on New Code
13.5% Duplication on New Code

See analysis details on SonarCloud

@Frotty Frotty merged commit 6859ece into master Jan 14, 2024
5 checks passed
@Frotty Frotty deleted the dev-fix-lua-issues branch January 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants