Drop dependency on SortedSet #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
casperisfine
force-pushed
the
fix-sorted-set
branch
from
8596b35
to
0a34095
Compare
casperisfine
commented
Dec 11, 2020
| @@ -7,10 +7,6 @@ platforms :jruby do | |||
| gem "jruby-openssl" | |||
| end | |||
|
|
|||
| platform :rbx do | |||
| gem "rubysl" | |||
There was a problem hiding this comment.
This was causing issues on CI.
casperisfine
force-pushed
the
fix-sorted-set
branch
from
0a34095
to
f0921e9
Compare
casperisfine
commented
Dec 11, 2020
| @decoding_map = decoding_map if decoding_map | ||
| @encoding_map = {} | ||
| freeze |
There was a problem hiding this comment.
I freeze the palette to validate my assumption that elements are not added to the set.
|
LGTM! I'll close my PR because I like this one better. |
wvanbergen
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #153
Regular
Set, since they are backed by aHash, keep the insertion order. From what I gathered the palette is built once, but is not mutated (I mean not added to, it has some internal mutation).Based on this, I believe that we can initialize a
Setwith a sorted array, which should give us the same result than aSortedSet.cc @wvanbergen @tenderlove @jeremy