ruby3_2 fix: check if object responds to regex_match op #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object#=~ is already deprecated since ruby2.6 and will be removed from ruby3.2. As the result, Array no longer respond to =~ from ruby3.2, for example. Check if the target object really respond to =~ . Closes wvanbergen#168
|
Any chance of getting this PR merged and released? It would enable use with Ruby 3.2+ |
thesamesam
added a commit
to thesamesam/gentoo
that referenced
this pull request
Mar 25, 2023
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 25, 2023
Bug: wvanbergen/chunky_png#169 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe there is more clean solution, however anyway proposing the fix.
Object#=~ is already deprecated since ruby2.6 and will be removed from ruby3.2. As the result, Array no longer respond to =~ from ruby3.2, for example.
Check if the target object really respond to =~ .
Closes #168