Synchronize German and English locales #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| units_to_order: Bestellte Gebinde | ||
| units_to_order: | ||
| one: Bestelltes Gebinde | ||
| other: Bestellte Gebinde |
There was a problem hiding this comment.
Reviewing this, I suddenly realise that adding pluralisation might break existing use. And indeed - the order_article form (opened from balancing) now shows the singular label, which is confusing. I've opened heartcombo/simple_form#974, and in the meantime we might workaround it by passing pluralised labels manually to applicable form inputs. What do you think?
There was a problem hiding this comment.
Good point, I have not realized that before. For simplicity, I could accept plural forms everywhere. But this might differ for other languages than English or German.
There was a problem hiding this comment.
Ok, I'll revert to using plural forms everywhere until there is an upstream solution.
wvengen
added a commit
that referenced
this pull request
Jan 11, 2014
Synchronize German and English locales
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in foodcoops#222 (comment).