Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the app on windows #3

Open
wvffle opened this issue Feb 13, 2020 · 25 comments
Open

Test the app on windows #3

wvffle opened this issue Feb 13, 2020 · 25 comments
Labels
help wanted Extra attention is needed

Comments

@wvffle
Copy link
Owner

wvffle commented Feb 13, 2020

Does everything work on windows?

@wvffle wvffle added the help wanted Extra attention is needed label Feb 13, 2020
@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

nope

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

C:\Users\me>mcpd C:\Users\me\AppData\Roaming\npm\node_modules\mcpd\lib\config.js:56 save(defaultConfig).then(({ error }) => { ^ ReferenceError: save is not defined at Object. (C:\Users\me\AppData\Roaming\npm\node_modules\mcpd\lib\config.js:56:3) at Module._compile (internal/modules/cjs/loader.js:1158:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10) at Module.load (internal/modules/cjs/loader.js:1002:32) at Function.Module._load (internal/modules/cjs/loader.js:901:14) at Module.require (internal/modules/cjs/loader.js:1044:19) at require (internal/modules/cjs/helpers.js:77:18) at Object. (C:\Users\me\AppData\Roaming\npm\node_modules\mcpd\lib\utils.js:3:20) at Module._compile (internal/modules/cjs/loader.js:1158:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)

@wvffle
Copy link
Owner Author

wvffle commented Mar 26, 2020

hmm
What's your node version?

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

C:\Users\me>node -v
v12.16.1

@wvffle wvffle mentioned this issue Mar 26, 2020
@wvffle
Copy link
Owner Author

wvffle commented Mar 26, 2020

hmm
seems to work well on 13.11.0 but I'll fix it

@Systemwartung

This comment has been minimized.

@wvffle
Copy link
Owner Author

wvffle commented Mar 26, 2020

@zRattly update mcpd and check now ;)

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

trying

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

Tryed connecting, crashed my minecraft lol

@wvffle
Copy link
Owner Author

wvffle commented Mar 26, 2020

For now 1.12.2 is hardcoded ;/

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

oh, tryed joining with 1.8.9 lol

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

but there are some errors in gui and console

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

{"statusCode":500,"code":"ENOENT","error":"Internal Server Error","message":"ENOENT: no such file or directory, open 'C:\Users\giova\public\index.html'"} this is the web error

@Rattlyy
Copy link

Rattlyy commented Mar 26, 2020

UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, mkdir 'C:\Users\me\AppData\Roaming\mcpd\Config' at Object.mkdirSync (fs.js:840:3) at C:\Users\giova\AppData\Roaming\npm\node_modules\mcpd\lib\config.js:59:12 (node:4568) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:4568) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. (this is in the console)

@wvffle
Copy link
Owner Author

wvffle commented Mar 26, 2020

@zRattly should've fixed those two errors

@Ethan-Vann
Copy link

still an issue in the latest release
Error

@wvffle
Copy link
Owner Author

wvffle commented Mar 31, 2020

@Ethan-Vann, there's an open PR for that #10

@wvffle wvffle mentioned this issue Apr 2, 2020
@wvffle
Copy link
Owner Author

wvffle commented Apr 3, 2020

@Ethan-Vann, @zRattly any news after #10 has been merged?

@Ethan-Vann
Copy link

Ethan-Vann commented Apr 3, 2020

should have tried this before. just switched to arch to test back then. is the npm build outdated? grabbing with npm produces same error but getting from source is working now

@wvffle
Copy link
Owner Author

wvffle commented Apr 3, 2020

Yup, use the github version

@Saiv46
Copy link
Contributor

Saiv46 commented Apr 3, 2020

Now we need to update NPM package and close this issue

@wvffle
Copy link
Owner Author

wvffle commented Apr 3, 2020

@Saiv46 so you confirm it working?

@Saiv46
Copy link
Contributor

Saiv46 commented Apr 14, 2020

Yep.

@Saiv46
Copy link
Contributor

Saiv46 commented Oct 3, 2021

@wvffle Fixed package version still not published :/

@wvffle
Copy link
Owner Author

wvffle commented Oct 3, 2021

Thanks for reminding me that. Currently I have no spare time for mineflayer related projects. Lots of work and also studies :/

I'll publish it in a minute

Edit: already done, @Saiv46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants