Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-http: #1086 Support query_string mapping for non GET requests #1087

Merged
merged 2 commits into from
May 16, 2020

Conversation

xerial
Copy link
Member

@xerial xerial commented May 15, 2020

This will close #1086

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #1087 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
+ Coverage   82.45%   82.47%   +0.01%     
==========================================
  Files         270      270              
  Lines       10292    10292              
  Branches      687      670      -17     
==========================================
+ Hits         8486     8488       +2     
+ Misses       1806     1804       -2     
Impacted Files Coverage Δ
...rc/main/scala/wvlet/airframe/surface/Surface.scala 70.00% <ø> (ø)
...wvlet/airframe/http/router/HttpRequestMapper.scala 96.96% <100.00%> (+3.03%) ⬆️
...frame/surface/reflect/RuntimeMethodParameter.scala 89.47% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6d52f...042890b. Read the comment docs.

@xerial
Copy link
Member Author

xerial commented May 16, 2020

cc: @takezoe @shimamoto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airframe-http: query_string mapping support for non-GET requests
1 participant