Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-rx: Add Rx.cache.getCurrent #1572

Merged
merged 1 commit into from Apr 2, 2021
Merged

airframe-rx: Add Rx.cache.getCurrent #1572

merged 1 commit into from Apr 2, 2021

Conversation

xerial
Copy link
Member

@xerial xerial commented Apr 2, 2021

I've found it's necessary to implement components that have some public methods referencing Rx data:

class Selector extends RxElement { 
   private val list = getList.map(x => ...).cache 

   def selected = list.getCurrent.map(lst => lst(selectedIndex))
}

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1572 (816eb64) into master (b46be2a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1572      +/-   ##
==========================================
- Coverage   82.94%   82.94%   -0.01%     
==========================================
  Files         306      306              
  Lines       12146    12147       +1     
  Branches      740      740              
==========================================
  Hits        10075    10075              
- Misses       2071     2072       +1     
Impacted Files Coverage Δ
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 81.01% <100.00%> (+0.24%) ⬆️
...rx/src/main/scala/wvlet/airframe/rx/RxOption.scala 55.81% <100.00%> (+1.05%) ⬆️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 91.92% <0.00%> (-0.45%) ⬇️
...shared/src/main/scala/wvlet/log/io/StopWatch.scala 80.00% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46be2a...816eb64. Read the comment docs.

@xerial
Copy link
Member Author

xerial commented Apr 2, 2021

cc: @shimamoto

@xerial xerial merged commit 6fa6468 into master Apr 2, 2021
@exoego exoego deleted the rx-cache-get branch February 4, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant