Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize JSON object builder #216

Merged
merged 8 commits into from
Aug 21, 2018
Merged

Optimize JSON object builder #216

merged 8 commits into from
Aug 21, 2018

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 21, 2018

Optimize JSONObject builder by directly pushing JSONValues into JSONContext (stack)

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #216 into master will decrease coverage by 1.05%.
The diff coverage is 82.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   83.71%   82.66%   -1.06%     
==========================================
  Files         129      131       +2     
  Lines        5067     5128      +61     
  Branches      520      519       -1     
==========================================
- Hits         4242     4239       -3     
- Misses        825      889      +64
Impacted Files Coverage Δ
...shared/src/main/scala/wvlet/log/io/StopWatch.scala 80% <100%> (-3.34%) ⬇️
...json/src/main/scala/wvlet/airframe/json/JSON.scala 60.97% <100%> (+0.44%) ⬆️
...n/scala/wvlet/airframe/json/JSONEventHandler.scala 100% <100%> (ø)
...in/scala/wvlet/airframe/json/NullJSONContext.scala 72.72% <72.72%> (ø)
...c/main/scala/wvlet/airframe/json/JSONScanner.scala 80.65% <78.78%> (-1.26%) ⬇️
...n/scala/wvlet/airframe/json/JSONValueBuilder.scala 83.78% <83.78%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b83bea...531c963. Read the comment docs.

@xerial xerial merged commit ac3ba86 into master Aug 21, 2018
@xerial xerial deleted the json-push-interface branch August 21, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant