Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airframe-surface: EnumSurface needs to remove dependency to TypeConverter for Scala.js #2396

Closed
xerial opened this issue Sep 5, 2022 · 0 comments · Fixed by #2398
Closed

airframe-surface: EnumSurface needs to remove dependency to TypeConverter for Scala.js #2396

xerial opened this issue Sep 5, 2022 · 0 comments · Fixed by #2398
Assignees
@xerial
Milestone
Scala 3

Comments

@xerial
Copy link
Member

xerial commented Sep 5, 2022 

$ cd airspec
$ DOTTY=true ../sbt 
> airspecJS/clean
> airspecJS/compile

[error] -- [E008] Not Found Error: /Users/leo/work/git/airframe/airspec/../airframe-surface/src/main/scala-3/wvlet/airframe/surface/CompileTimeSurfaceFactory.scala:421:64
[error] 421 |          { (cl: Class[_], s: String) => wvlet.airframe.surface.reflect.TypeConverter.convertToCls(s, cl) }
[error]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]     |               value reflect is not a member of wvlet.airframe.surface
[error] -- [E008] Not Found Error: /Users/leo/work/git/airframe/airspec/../airframe-surface/src/main/scala-3/wvlet/airframe/surface/CompileTimeSurfaceFactory.scala:653:31
[error] 653 |        wvlet.airframe.surface.reflect
[error]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]     |        value reflect is not a member of wvlet.airframe.surface
@xerial xerial added this to the Scala 3 milestone Sep 5, 2022
@xerial xerial changed the title airframe-surface: Remove dependency to TypeConverter for Scala.js airframe-surface: EnumSurface needs to remove dependency to TypeConverter for Scala.js Sep 5, 2022
@xerial xerial self-assigned this Sep 5, 2022
@xerial xerial mentioned this issue Sep 5, 2022
Merged
xerial added a commit that referenced this issue Sep 6, 2022
@xerial
airframe-surface: #2396 Build EnumSurface without reflection
92187c5
@xerial xerial mentioned this issue Sep 6, 2022
Merged
xerial added a commit that referenced this issue Sep 6, 2022
@xerial
airframe-surface: #2396 Build EnumSurface without reflection (#2398)
4eab8bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xerial xerial

Labels
None yet
Projects
None yet
Milestone
Scala 3
Development

Successfully merging a pull request may close this issue.

airframe-surface: #2396 Build EnumSurface without reflection wvlet/airframe
1 participant
@xerial