Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rx: RxOptionVar cannot be used in design #3131

Closed
xerial opened this issue Aug 11, 2023 · 0 comments · Fixed by #3149
Closed

rx: RxOptionVar cannot be used in design #3131

xerial opened this issue Aug 11, 2023 · 0 comments · Fixed by #3149
Assignees
@xerial
Labels
bug

Comments

@xerial
Copy link
Member

xerial commented Aug 11, 2023

example: MainFrame(v: RxOptionVar[ErrorMessage])

[error] 38 |    val mainPanel = session.build[MainFrame]
[error]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^
[error]    |           Found:    wvlet.airframe.rx.RxVar[Option[A]][Option[A]]
[error]    |           Required: wvlet.airframe.rx.RxVar[
[error]    |             Option[ErrorMessage]]
@xerial xerial added the bug label Aug 11, 2023
@xerial xerial self-assigned this Aug 11, 2023
@xerial xerial changed the title rx: RxOptionVar cannot be bubd in design rx: RxOptionVar cannot be used in design Aug 11, 2023
@xerial xerial mentioned this issue Aug 21, 2023
Merged
2 tasks
xerial added a commit that referenced this issue Aug 21, 2023
@xerial
surface (fix): Reduce the bytecode size of Surface.methodsOf for Scal…
0b94a88 
…a 3 (#3149)

This fixes byte code too large error when using RxRouter.of[X] or
Surface.methodsOf[X] when class X has many methods and repeated
occurrences of the same parameters.

- Bind surface to local lazy val __s000, __s001, ... and reference them
when building other Surfaces and MethodSurfaces
  - Add a special handling for managing lazy surface
- Fixes #3131 as well 
- Reuse object methods when generating method accessor and object
factory.

Other ideas
- [x] Use externally defined methods for field setter and object builder
- [x] Reuse Surface inside OptionSurface, GenericSurface by analyzing
dependencies of Surface fixes #3150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xerial xerial

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

surface (fix): Reduce the bytecode size of Surface.methodsOf for Scala 3 wvlet/airframe
1 participant
@xerial