Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finagle-core, finagle-http, ... to 20.4.0 #1024

Merged
merged 1 commit into from Apr 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
Expand Up @@ -17,7 +17,7 @@ val SQLITE_JDBC_VERSION = "3.30.1"
val SLF4J_VERSION = "1.7.30"
val JS_JAVA_LOGGING_VERSION = "1.0.0"
val JS_JAVA_TIME_VERSION = "1.0.0"
val FINAGLE_VERSION = "20.3.0"
val FINAGLE_VERSION = "20.4.0"
val FLUENCY_VERSION = "2.4.1"
val SCALAJS_DOM_VERSION = "1.0.0"

Expand Down
2 changes: 1 addition & 1 deletion docs/release-notes.md
Expand Up @@ -35,7 +35,7 @@ New Features:
- airframe-http: Support Scala.js for defining Web interfaces as well as Scala JVM [[0e017db](https://github.com/wvlet/airframe/commit/0e017db)]
- airframe-http: Support adding a custom codec to clients ([#1004](https://github.com/wvlet/airframe/issues/1004)) [[9675669](https://github.com/wvlet/airframe/commit/9675669)]
- airframe-http: Add cross-platform HttpMessage.Request and Response classes ([#982](https://github.com/wvlet/airframe/issues/982)) [[f55d438](https://github.com/wvlet/airframe/commit/f55d438)]
- airframe-http-finagle: Update finagle-core, finagle-http, ... to 20.3.0 ([#965](https://github.com/wvlet/airframe/issues/965)) [[111e5ad](https://github.com/wvlet/airframe/commit/111e5ad)]
- airframe-http-finagle: Update finagle-core, finagle-http, ... to 20.4.0 ([#965](https://github.com/wvlet/airframe/issues/965)) [[111e5ad](https://github.com/wvlet/airframe/commit/111e5ad)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not update the past release notes. This line must be reverted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know scala-steward changes such release notes too. I'll be more careful next time 😓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was really surprised that scala-steward can change this part.

- airframe-http-rx: [#993](https://github.com/wvlet/airframe/issues/993) Support Future[X] to Rx[X] conversion ([#996](https://github.com/wvlet/airframe/issues/996)) [[b54bbe7](https://github.com/wvlet/airframe/commit/b54bbe7)]
- airframe-http-rx: [#961](https://github.com/wvlet/airframe/issues/961) Support add/overwrite of DOM attributes ([#976](https://github.com/wvlet/airframe/issues/976)) [[02b54b2](https://github.com/wvlet/airframe/commit/02b54b2)]
- airframe-codec: Add Unit codec ([#980](https://github.com/wvlet/airframe/issues/980)) [[58ef3ff](https://github.com/wvlet/airframe/commit/58ef3ff)]
Expand Down