airframe-log: Dotty support #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xerial
commented
Dec 5, 2020
•
xerial
commented
- Switch sources between Scala 2 and 3
- Use new Macros
- Similar example https://github.com/Log4s/log4s/pull/57/files
- Added simple integration tests. To run AirSpec tests with Dotty, we also need to migrate surface, di, metrics.
- Added a release configuration
Closed
|
@takezoe @shimamoto It's the first step for supporting Dotty (Scala 3). Because Scala 3 introduces new macros https://scalacenter.github.io/scala-3-migration-guide/docs/macros/migration-tutorial.html, we need to split code for Scala 2 and 3. For now, it works as expected. After merging this PR, I'll release airframe-log for Scala 3.0.0-M2. |
62 tasks
xerial
added a commit
to xerial/scala-3-migration-guide
that referenced
this pull request
Dec 5, 2020
airframe-log is one of the modules of Airframe project https://wvlet.org/airframe. It's ported to Scala 3 macros wvlet/airframe#1381
xerial
added a commit
to xerial/scala-3-migration-guide
that referenced
this pull request
Dec 5, 2020
airframe-log is one of the modules of Airframe project https://wvlet.org/airframe. It's ported to Scala 3 macros wvlet/airframe#1381
adpi2
pushed a commit
to scalacenter/scala-3-migration-guide
that referenced
this pull request
Dec 7, 2020
airframe-log is one of the modules of Airframe project https://wvlet.org/airframe. It's ported to Scala 3 macros wvlet/airframe#1381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.