Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-di: Next generation DI #1653

Merged
merged 17 commits into from
May 15, 2021
Merged

airframe-di: Next generation DI #1653

merged 17 commits into from
May 15, 2021

Conversation

xerial
Copy link
Member

@xerial xerial commented May 14, 2021

Based on idea #1649

  • Deprecate in-trait binding
  • Add tests
  • Doc
  • Scala 3 support

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1653 (0c192d5) into master (8aa6f9c) will decrease coverage by 0.92%.
The diff coverage is 62.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
- Coverage   83.11%   82.19%   -0.93%     
==========================================
  Files         312      330      +18     
  Lines       12503    13096     +593     
  Branches      777      799      +22     
==========================================
+ Hits        10392    10764     +372     
- Misses       2111     2332     +221     
Impacted Files Coverage Δ
...scala/wvlet/airframe/di/tracing/ChromeTracer.scala 0.00% <0.00%> (ø)
...cala-2/wvlet/airframe/di/AirframeSessionImpl.scala 0.00% <0.00%> (ø)
...main/scala/wvlet/airframe/di/tracing/DIStats.scala 26.82% <26.82%> (ø)
...-di/src/main/scala/wvlet/airframe/di/Session.scala 42.85% <42.85%> (ø)
...e-di/src/main/scala/wvlet/airframe/di/LazyF0.scala 45.45% <45.45%> (ø)
...e-di/src/main/scala/wvlet/airframe/di/Binder.scala 61.11% <61.11%> (ø)
...la/wvlet/airframe/di/lifecycle/LifeCycleHook.scala 66.66% <66.66%> (ø)
...main/scala/wvlet/airframe/di/AirframeSession.scala 75.83% <75.83%> (ø)
...wvlet/airframe/di/lifecycle/LifeCycleManager.scala 78.68% <78.68%> (ø)
...c/main/scala/wvlet/airframe/di/DesignOptions.scala 80.00% <80.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca402a6...0c192d5. Read the comment docs.

@xerial xerial changed the title airframe-di: Next generation airframe-di: Next generation DI May 14, 2021
@xerial
Copy link
Member Author

xerial commented May 15, 2021

Removing in-train injection to simplify the DI framework is done. I'll work on Scala3 support later. We may also need to refine some APIs (e.g. design.build { (a: App) => ... } might be better than design.build[App] { (a: App) => ... }

@xerial xerial merged commit 1a57258 into wvlet:master May 15, 2021
@xerial xerial added this to the Scala 3 milestone May 25, 2021
@xerial xerial mentioned this pull request Feb 3, 2022
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant