Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sbt-airframe as a separate GitHub project #1686

Merged
merged 2 commits into from
May 22, 2021

Conversation

xerial
Copy link
Member

@xerial xerial commented May 22, 2021

This PR extracts sbt-airframe module as a separate GitHub project https://github.com/wvlet/sbt-airframe.

This is for simplifying the cross build settings.
Currently, sbt-plugin must use only Scala 2.12, while the other airframe modules can be built with Scala 2.13 and Scala 3.
Having a sbt-plugin inside the same project has caused a lot of dependency errors when switching to Scala 2.13 or Scala 3.

With this change, we can make the default Scala version of Airframe at least to Scala 2.13. And also, cross building Scala.js projects with Scala 3 will be possible.

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #1686 (c186a69) into master (7242187) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         310      310           
  Lines       12253    12253           
  Branches      753      753           
=======================================
+ Hits        10142    10143    +1     
+ Misses       2111     2110    -1     
Impacted Files Coverage Δ
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 91.22% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8737125...c186a69. Read the comment docs.

@xerial xerial mentioned this pull request May 22, 2021
62 tasks
@xerial
Copy link
Member Author

xerial commented May 22, 2021

cc: @wvlet/airframe-dev

@xerial xerial merged commit cb238c8 into wvlet:master May 22, 2021
@xerial xerial added this to the Scala 3 milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant