Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-grpc: Propagate RPCException to clients #2139

Merged
merged 7 commits into from
Apr 27, 2022
Merged

Conversation

xerial
Copy link
Member

@xerial xerial commented Apr 27, 2022

Embed RPCException to gRPC trailer so that the client can receive detailed RPCException.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2139 (7f5cbc4) into master (27cb12c) will increase coverage by 0.16%.
The diff coverage is 87.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
+ Coverage   82.50%   82.67%   +0.16%     
==========================================
  Files         301      305       +4     
  Lines       11837    12057     +220     
  Branches      759      739      -20     
==========================================
+ Hits         9766     9968     +202     
- Misses       2071     2089      +18     
Impacted Files Coverage Δ
...rframe/http/grpc/internal/GrpcRequestHandler.scala 74.40% <ø> (ø)
.../grpc/internal/GrpcResponseHeaderInterceptor.scala 100.00% <ø> (ø)
...http/src/main/scala/wvlet/airframe/http/Http.scala 75.47% <ø> (ø)
...rc/main/scala/wvlet/airframe/http/HttpStatus.scala 91.20% <0.00%> (-8.80%) ⬇️
.../main/scala/wvlet/airframe/msgpack/spi/Value.scala 82.39% <ø> (ø)
...let/airframe/surface/reflect/ReflectTypeUtil.scala 84.44% <ø> (ø)
...c/main/scala/wvlet/airframe/http/HttpMessage.scala 80.35% <66.66%> (-0.38%) ⬇️
...src/main/scala/wvlet/airframe/http/RPCStatus.scala 85.24% <85.24%> (ø)
...rc/main/scala/wvlet/airframe/http/GrpcStatus.scala 87.87% <87.87%> (ø)
...in/scala/wvlet/airframe/codec/PrimitiveCodec.scala 84.76% <92.85%> (-0.19%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b463e...7f5cbc4. Read the comment docs.

@xerial xerial merged commit 7f21193 into master Apr 27, 2022
@xerial xerial deleted the rpc-exception branch June 2, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant