airframe-sql: Intersect should have attributes of all source relations #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2589 +/- ##
==========================================
+ Coverage 81.97% 82.01% +0.04%
==========================================
Files 333 333
Lines 13734 13748 +14
Branches 2117 2148 +31
==========================================
+ Hits 11259 11276 +17
+ Misses 2475 2472 -3
Continue to review full report at Codecov.
|
takezoe
force-pushed
the
sql-resolve-intersect
branch
from
33205aa
to
a41e158
Compare
|
Build is failing for Scala 3 🤔 |
|
Removed debug logs |
|
Ah, remaining debug code was not Scala3 compatible. 🙇♂️ |
xerial
reviewed
Nov 25, 2022
| case class Intersect(relations: Seq[Relation], nodeLocation: Option[NodeLocation]) extends SetOperation { | ||
| case class Intersect( | ||
| relations: Seq[Relation], | ||
| resolvedOutputs: Option[Seq[Attribute]], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way as Union