Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-okhttp: Scala3 support prep. Remove Finagle from test dependency #2670

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

xerial
Copy link
Member

@xerial xerial commented Dec 25, 2022

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Merging #2670 (281d284) into master (7b7c3c7) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
+ Coverage   82.19%   82.33%   +0.13%     
==========================================
  Files         335      335              
  Lines       14047    14047              
  Branches     2241     2214      -27     
==========================================
+ Hits        11546    11565      +19     
+ Misses       2501     2482      -19     
Impacted Files Coverage Δ
...vlet/airframe/http/netty/NetthRequestHandler.scala 77.55% <100.00%> (+16.32%) ⬆️
...main/scala/wvlet/airframe/http/ServerAddress.scala 96.00% <100.00%> (ø)
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 95.27% <0.00%> (+0.39%) ⬆️
...c/main/scala/wvlet/airframe/http/HttpMessage.scala 85.12% <0.00%> (+0.82%) ⬆️
...let/airframe/http/netty/NettyResponseHandler.scala 52.00% <0.00%> (+36.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7c3c7...281d284. Read the comment docs.

@xerial xerial changed the title airframe-okhttp: Scala3 support airframe-okhttp: Scala3 support prep Dec 26, 2022
@xerial xerial marked this pull request as ready for review December 26, 2022 01:56
@xerial xerial changed the title airframe-okhttp: Scala3 support prep airframe-okhttp: Scala3 support prep. Remove Finagle from test dependency Dec 26, 2022
@xerial xerial added internal Internal changes (usually non-user facing) and removed feature labels Dec 26, 2022
@xerial xerial merged commit d9dea87 into master Dec 26, 2022
@xerial xerial deleted the okhttp-scala3 branch December 26, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant