Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-http: Add a new RxRouter interface for Scala and Scala.js #2689

Merged
merged 23 commits into from
Apr 20, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Jan 8, 2023

Add a prototype of new RxRouter interface for supporting Scala.js and Scala 3

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #2689 (507637c) into master (2ac7f2d) will increase coverage by 0.03%.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
+ Coverage   82.44%   82.47%   +0.03%     
==========================================
  Files         337      339       +2     
  Lines       14249    14341      +92     
  Branches     2293     2297       +4     
==========================================
+ Hits        11747    11828      +81     
- Misses       2502     2513      +11     
Impacted Files Coverage Δ
...rc/main/scala/wvlet/airframe/http/RxEndpoint.scala 0.00% <0.00%> (ø)
.../src/main/scala/wvlet/airframe/http/RxFilter.scala 0.00% <0.00%> (ø)
...in/scala/wvlet/airframe/http/router/RxRouter.scala 62.96% <62.96%> (ø)
...vm/src/main/scala/wvlet/airframe/http/Router.scala 90.24% <100.00%> (+2.74%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac7f2d...507637c. Read the comment docs.

@xerial xerial mentioned this pull request Apr 10, 2023
62 tasks
@xerial xerial marked this pull request as ready for review April 20, 2023 02:00
@xerial xerial merged commit 9caa352 into master Apr 20, 2023
24 checks passed
@xerial xerial deleted the rx-router branch April 20, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant