Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-http-netty: Fix empty response handling #2924

Merged
merged 5 commits into from
May 4, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented May 4, 2023

No description provided.

@github-actions github-actions bot added the bug label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #2924 (e50f43f) into master (103acde) will increase coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head e50f43f differs from pull request most recent head 0fcb5c3. Consider uploading reports for the commit 0fcb5c3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
+ Coverage   82.78%   82.79%   +0.01%     
==========================================
  Files         345      345              
  Lines       14543    14549       +6     
  Branches     2374     2398      +24     
==========================================
+ Hits        12039    12046       +7     
+ Misses       2504     2503       -1     
Impacted Files Coverage Δ
...scala/wvlet/airframe/http/client/HttpClients.scala 79.67% <81.81%> (-1.00%) ⬇️
...vlet/airframe/http/netty/NetthRequestHandler.scala 80.00% <100.00%> (+0.68%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103acde...0fcb5c3. Read the comment docs.

@xerial xerial merged commit f6280d0 into master May 4, 2023
23 checks passed
@xerial xerial deleted the json-response-handling branch May 4, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant