surface (fix): Reduce generated code size for MethodSurface in Scala 3 #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerial
force-pushed
the
reduce-method-surface-bytecode
branch
from
197742c
to
f6dd617
Compare
xerial
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3146 +/- ##
=======================================
Coverage 82.89% 82.90%
=======================================
Files 350 350
Lines 14740 14740
Branches 2443 2443
=======================================
+ Hits 12219 12220 +1
+ Misses 2521 2520 -1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
xerial
force-pushed
the
reduce-method-surface-bytecode
branch
from
f6dd617
to
84ee17b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a huge byte code issue, failed with:
[error] Generated bytecode for method (extending RxRouterProvider) is too large. Size: 159519 bytes. Limit is 64KBmessage